On 7 June 2018 at 16:14, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > The current codebase is a mix of v1 registers and v2 commands (which > were added slowly without updating all registers). > As of now v1 is broken (See the lm3s6965evb machine can not use the > card) and all users are using v2. > My goal with these series is to also support v3. > > It might be more obvious to first enforce the current implementation is > v2, then restore v1 support and go for v3. I think this is doable by an > easy rebase of this series (keep v2 and restore v1). > > Do you think this is better?
I don't have a strong opinion (you have a better grasp of the specs than me); I'd just like justification for why we do what we do in the commit messages and/or comments as appropriate. thanks -- PMM