* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" <dgilb...@redhat.com> writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Peter Xu <pet...@redhat.com> writes: > >> > >> > On Tue, Jun 05, 2018 at 01:26:34PM +0100, Dr. David Alan Gilbert (git) > >> > wrote: > >> >> From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > >> >> > >> >> Allow a bunch of the info commands to be used in preconfig. > >> >> Could probably add most of them. > >> > > >> > I guess some of them may not work yet during preconfig. E.g.: > >> > > >> > $ ./x86_64-softmmu/qemu-system-x86_64 -preconfig -monitor stdio > >> > QEMU 2.12.50 monitor - type 'help' for more information > >> > (qemu) info mtree > >> > address-space: memory > >> > 0000000000000000-ffffffffffffffff (prio 0, i/o): system > >> > > >> > address-space: I/O > >> > 0000000000000000-000000000000ffff (prio 0, i/o): io > >> > > >> > But it's fine to enable that I guess. > >> > > >> > (Which "info" command would you want to use during preconfig?) > >> > > >> >> > >> >> Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > >> > > >> > Reviewed-by: Peter Xu <pet...@redhat.com> > >> > >> The reason for having -preconfig is us despairing of making -S do the > >> right thing. We'd have to *understand* the tangled mess that is our > >> startup, and rearrange it so QMP becomes available early enough for > >> configuring NUMA (and other things), yet late enough for everything to > >> work. > >> > >> -preconfig is a cheap hack to avoid this headache, by bypassing almost > >> all of "everything". > >> > >> Now you bring back some of "everything". Dangerous. You better show it > >> actually works. Until you do: > >> > >> NAK > > > > Well I did test each command in here to make sure it didn't > > crash/produce complete junk; but here's the output with the v2 of this > > patch that Igor R-b: > [...] > > For the sake of the argument, let's assume these commands all work in > preconfig state. Are their QMP equivalents all available in preconfig > state?
That I don't know; I was happy to fix my list to the ones Igor recommended. If you object to some particular entries I'll be happy to change them. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
