On 06/12/2018 09:15 AM, Eric Blake wrote: > On 06/12/2018 03:28 AM, Daniel P. Berrangé wrote: >> When configure fails in CI systems we must be able to see the contents >> of the config.log file to diagnose the root cause. >> >> Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> >> --- >> .travis.yml | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/.travis.yml b/.travis.yml >> index 814be151f4..fc9a1fe8a8 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -69,7 +69,7 @@ before_install: >> - wget -O - >> http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | >> tar -xvJ >> - git submodule update --init --recursive >> before_script: >> - - ./configure ${CONFIG} >> + - ./configure ${CONFIG} || (cat config.log && exit 1) > > If you want one less fork, you can spell this as: > > - ./configure ${CONFIG} || { cat config.log && exit 1; }
I was just digging for your previous mail explaining that to use as reference ;) > > Either way, the patch makes sense, so: > Reviewed-by: Eric Blake <ebl...@redhat.com> > preferably using {: Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>