On 06/12/2018 06:37 AM, Philippe Mathieu-Daudé wrote: >> /* Both preadv and pwritev merge args 4/5 into a 64-bit offset. >> * Moreover, the parts are *always* in little-endian order. >> */ >> #if TARGET_ABI_BITS == 32 >> SYSCALL_ARGS(preadv_pwritev) >> { >> - /* We have already assigned out[0-3]. */ >> - abi_ulong lo = in[4], hi = in[5]; >> - out[4] = ((hi << (TARGET_ABI_BITS - 1)) << 1) | lo; >> + /* We have already assigned out[0-2]. */ >> + abi_ulong lo = in[3], hi = in[4]; >> + out[3] = ((hi << (TARGET_ABI_BITS - 1)) << 1) | lo; > Why this change? If correct, can you update the comment? > Also this seems related to your previous patch #14: "Split out preadv, > pwritev, readv, writev", not this one. >
You're right, this hunk should be folded back into the previous patch. r~