Am 14.06.2018 um 21:14 hat Markus Armbruster geschrieben: > Remaining uses of qobject_input_visitor_new_keyval() in the block > subsystem: > > * block_crypto_create_opts_init()
Still the wrong function name. Will fix this while applying. (Should be block_crypto_open_opts_init()) > Currently doesn't visit any non-string scalars, thus safe. It's > called from > - block_crypto_open_luks() > Creates the QDict with qemu_opts_to_qdict_filtered(), which > creates only string scalars, but has a TODO asking for other types. > - qcow_open() > - qcow2_open(), qcow2_co_invalidate_cache(), qcow2_reopen_prepare() > > * block_crypto_create_opts_init(), called from > - block_crypto_co_create_opts_luks() > Also creates the QDict with qemu_opts_to_qdict_filtered(). > > * vdi_co_create_opts() > Also creates the QDict with qemu_opts_to_qdict_filtered(). > > Replace these uses by qobject_input_visitor_new_flat_confused() for > robustness. This adds crumpling. Right now, that's a no-op, but if > we ever extend these things in non-flat ways, crumpling will be > needed. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> Kevin
