On 15.06.2018 14:46, Igor Mammedov wrote:
> On Fri, 15 Jun 2018 13:24:56 +0200
> David Hildenbrand <da...@redhat.com> wrote:
>
>> Our parent class (PC_DIMM) provides exactly the same function.
>>
>> Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
>> Reviewed-by: Igor Mammedov <imamm...@redhat.com>
>> Signed-off-by: David Hildenbrand <da...@redhat.com>
>> ---
>> hw/mem/nvdimm.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
>> index 37e19044d6..df9716231f 100644
>> --- a/hw/mem/nvdimm.c
>> +++ b/hw/mem/nvdimm.c
>> @@ -166,11 +166,6 @@ static void nvdimm_write_label_data(NVDIMMDevice
>> *nvdimm, const void *buf,
>> memory_region_set_dirty(mr, backend_offset, size);
>> }
>>
>> -static MemoryRegion *nvdimm_get_vmstate_memory_region(PCDIMMDevice *dimm)
>> -{
>> - return host_memory_backend_get_memory(dimm->hostmem, &error_abort);
>> -}
>> -
>> static void nvdimm_class_init(ObjectClass *oc, void *data)
>> {
>> PCDIMMDeviceClass *ddc = PC_DIMM_CLASS(oc);
>> @@ -178,7 +173,6 @@ static void nvdimm_class_init(ObjectClass *oc, void
>> *data)
>>
>> ddc->realize = nvdimm_realize;
>> ddc->get_memory_region = nvdimm_get_memory_region;
>> - ddc->get_vmstate_memory_region = nvdimm_get_vmstate_memory_region;
>>
>> nvc->read_label_data = nvdimm_read_label_data;
>> nvc->write_label_data = nvdimm_write_label_data;
>
> maybe put this patch before 7/12 ?
>
Yes, that's how it was before moving all nvdimm patches into one chunk.
--
Thanks,
David / dhildenb
