On Tue, 19 Jun 2018 18:56:31 +1000 Alexey Kardashevskiy <a...@ozlabs.ru> wrote:
> This fixes uninitialized variable warning: > > /home/aik/p/qemu/hw/intc/xics_kvm.c: In function ‘ics_set_kvm_state’: > /home/aik/p/qemu/hw/intc/xics_kvm.c:281:20: warning: ‘ret’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > return ret; > ^~~ > > Discovered with gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 from Ubuntu 18.04. > > Fixes: bf358b541b8 "xics_kvm: use KVM helpers" > Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru> > --- Already fixed and present in David's last pull req: https://lists.nongnu.org/archive/html/qemu-ppc/2018-06/msg00682.html > hw/intc/xics_kvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/intc/xics_kvm.c b/hw/intc/xics_kvm.c > index 8bdf6af..48efbce 100644 > --- a/hw/intc/xics_kvm.c > +++ b/hw/intc/xics_kvm.c > @@ -273,8 +273,8 @@ static int ics_set_kvm_state(ICSState *ics, int > version_id) > state |= KVM_XICS_QUEUED; > } > > - kvm_device_access(kernel_xics_fd, KVM_DEV_XICS_GRP_SOURCES, > - i + ics->offset, &state, true, &local_err); > + ret = kvm_device_access(kernel_xics_fd, KVM_DEV_XICS_GRP_SOURCES, > + i + ics->offset, &state, true, &local_err); > if (local_err) { > error_report("Unable to restore KVM interrupt controller state" > " for IRQs %d: %s", i + ics->offset, strerror(errno));
