On Thu, Jun 21, 2018 at 01:23:47PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé <berra...@redhat.com> writes: > > > On Thu, Jun 21, 2018 at 10:35:51AM +0200, Markus Armbruster wrote: > >> Fix the following issues: > >> > >> common.py:873:13: E129 visually indented line with same indent as next > >> logical line > >> common.py:1766:5: E741 ambiguous variable name 'l' > >> common.py:1784:1: E305 expected 2 blank lines after class or function > >> definition, found 1 > >> common.py:1833:1: E305 expected 2 blank lines after class or function > >> definition, found 1 > >> common.py:1843:1: E305 expected 2 blank lines after class or function > >> definition, found 1 > >> visit.py:181:18: E127 continuation line over-indented for visual indent > >> > >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > >> --- > >> scripts/qapi/common.py | 15 +++++++++------ > >> scripts/qapi/visit.py | 2 +- > >> 2 files changed, 10 insertions(+), 7 deletions(-) > > > > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > > > > > > If we care about pycodestyle-3 compliance, it is probably worth adding > > that to 'make check' to avoid people introducing regressions. > > It's not spotless, yet: > > $ pycodestyle-3 scripts/qapi-gen.py scripts/qapi/*.py > scripts/qapi/commands.py:66:80: E501 line too long (93 > 79 characters) > scripts/qapi/common.py:818:49: E261 at least two spaces before inline comment > scripts/qapi/visit.py:24:80: E501 line too long (86 > 79 characters) > scripts/qapi/visit.py:117:80: E501 line too long (88 > 79 characters) > scripts/qapi/visit.py:154:80: E501 line too long (87 > 79 characters) > scripts/qapi/visit.py:167:80: E501 line too long (88 > 79 characters) > scripts/qapi/visit.py:237:80: E501 line too long (88 > 79 characters) > > The long lines are in mcgen() arguments. > > If cleaning these up is the price for automation, I guess we'll pay it.
FWIW, --select=XXX or --ignore=XXX args let you turn off classes of warning we don't wish to fix. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
