On 07/02/2018 11:22 AM, Markus Armbruster wrote:
Wrapping global variables in a struct without a use for the wrapper
struct buys us nothing but longer lines.  Unwrap them.

Well, it also makes it slightly more obvious where you are using a global variable, and thus need to be careful of reentrancy. But I'm not opposed to this reduction in size.


Signed-off-by: Markus Armbruster <arm...@redhat.com>
---
  monitor.c | 60 +++++++++++++++++++++++++++----------------------------
  1 file changed, 29 insertions(+), 31 deletions(-)


Reviewed-by: Eric Blake <ebl...@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply via email to