Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()

[Dou Liyang]

Hi Eduardo,

At 07/10/2018 06:27 PM, Eduardo Habkost wrote:

On Tue, Jul 10, 2018 at 04:15:30PM +0800, Dou Liyang wrote:
[...]

+    if (nb_numa_nodes)
           machine_numa_finish_cpu_init(machine);
-    }

missing curly brackets, should look like:
         if (nb_numa_nodes) {
             machine_numa_finish_cpu_init(machine);
         }

with that fixed
Reviewed-by: Igor Mammedov <imamm...@redhat.com>

Thank you, Igor.

Due to Eduardo has sent the pull request of this patch,
Can I fix this and send v2 patch now?

You can fix this on a follow-up patch and CC qemu-trivial.

Ok, I see. ;-)

Thanks,
        dou