On 11/07/2018 18:00, Eduardo Habkost wrote: >> @@ -237,7 +237,7 @@ int x86_cpu_write_elf32_note(WriteCoreDumpFunction f, >> CPUState *cs, >> * please count up QEMUCPUSTATE_VERSION if you have changed definition of >> * QEMUCPUState, and modify the tools using this information accordingly. > Where are the tools using this information, that need to be > updated? Won't this break existing versions of those tools?
I think it's okay to _not_ change the version, since the format is backwards-compatible. Each QEMUCPUState struct is in a separate ELF note, and the presence of the new field is visible in both 1) the size of the note 2) the size field of the struct. Another possibility is to stash kernel_gs_base in cr. This approach doesn't scale, but the word is otherwise unused if we want to make it super safe. I don't recommend it. Paolo > Is the dump format and pointers to available tools documented > somewhere? > >