Markus Armbruster <arm...@redhat.com> wrote: > Leaving interpolation into JSON to qmp() is more robust than building > QMP input manually, as explained in the recent commit "tests: Clean up > string interpolation into QMP input (simple cases)". > > migration-test.c interpolates strings into JSON in a few places: > > * migrate_set_parameter() interpolates string parameter @value as a > JSON number. Change it to long long. This requires changing > migrate_check_parameter() similarly. > > * migrate_set_capability() interpolates string parameter @value as a > JSON boolean. Change it to bool. > > * deprecated_set_speed() interpolates string parameter @value as a > JSON number. Change it to long long. > > Bonus: gets rid of non-literal format strings. A step towards > compile-time format string checking without triggering > -Wformat-nonliteral. > > Cc: Juan Quintela <quint...@redhat.com> > Cc: Dr. David Alan Gilbert <dgilb...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com>
Reviewed-by: Juan Quintela <quint...@redhat.com> I did it someway because at some point I was also using strings, not only ints. But I came to conclusion that it is much better to just having different functions for different types. Thanks, again.
