On 07/15/2018 05:59 PM, BALATON Zoltan wrote:
> Coverity warned that the false arm of conditional expression is
> unreachable when it is inside an if with the same condition.
> Remove the unreachable code to avoid the warning.
>
> Fixes: CID 1394215
> Reported-by: Paolo Bonzini <pbonz...@redhat.com>
> Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> ---
> hw/display/sm501.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 9ab29d3..874260a 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -1024,7 +1024,7 @@ static void sm501_i2c_write(void *opaque, hwaddr addr,
> uint64_t value,
> if (res) {
> SM501_DPRINTF("sm501 i2c : transfer failed"
> " i=%d, res=%d\n", i, res);
> - s->i2c_status |= (res ? SM501_I2C_STATUS_ERROR :
> 0);
> + s->i2c_status |= SM501_I2C_STATUS_ERROR;
> return;
> }
> }
>
