On 18/07/2018 16:23, Stefan Hajnoczi wrote:
>>>> +struct QOSGraphObject {
>>>> + /* for produces, returns void * */
>>>> + QOSGetDriver get_driver;
>>> Unused?
>>>
>>>> + /* for contains, returns a QOSGraphObject * */
>>>> + QOSGetDevice get_device;
>>> Unused?
>> What is unused?
> Neither of these fields are used in this patch. Please introduce them
> in the first patch that actually uses them. This way code review can
> proceed linearly and it also prevents deadcode when just part of a patch
> series is merged or backported.
So do you suggest to squash patch 6 into this one, so that a user of
QOSGraphObject exists already here?
Thanks,
Paolo
