On 18/07/2018 19:14, Markus Armbruster wrote: >> The main challenge to me seems "how can we make tests simpler?". The >> presence of a new API and object model raises the bar for writing and >> running tests. I hope all qtests will use qgraph but if the complexity >> is too high then qgraph may only be used in a few niche cases where >> authors think it's worth abstracting machine types and others will >> continue to write qtests without qgraph. > The #1 reason for writing code a certain way is following existing > examples. As long as "qtest without qgraph" is prevalent in existing > tests, it'll remain prevalent in new tests. I'm afraid we'll need a > conversion effort. >
Indeed, Emanuele is already working on converting virtio-serial tests (virtio is possibly the largest part of libqos). The various nop tests are also more or less trivial to adjust. Paolo
