On 07/19/2018 05:54 AM, Stefan Markovic wrote: > +static void gen_p_lsx(DisasContext *ctx, int rd, int rs, int rt) > +{ > + TCGv t0, t1; > + t0 = tcg_temp_new(); > + t1 = tcg_temp_new(); > + tcg_gen_movi_tl(t1, 0); > + if (rs == 0) { > + tcg_gen_movi_tl(t0, 0); > + } else { > + gen_load_gpr(t0, rs); > + } > + if (rt == 0) { > + tcg_gen_movi_tl(t1, 0); > + } else { > + gen_load_gpr(t1, rt); > + }
gen_load_gpr already takes care of register 0. And what is that initial redundant assignment to t1? r~