On 25 July 2018 at 17:01, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 25 July 2018 at 10:48, Daniel P. Berrangé <berra...@redhat.com> wrote: >> On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: >>> For the Aarch64, there is one machine 'virt', it is primarily meant to >>> run on KVM and execute virtualization workloads, but we need an >>> environment as faithful as possible to physical hardware, for supporting >>> firmware and OS development for pysical Aarch64 machines. >>> >>> This patch introduces new machine type 'Enterprise' with main features: >> >> The 'enterprise' name is really awful - this is essentially a marketing >> term completely devoid of any useful meaning. >> >> You had previously called this "sbsa" which IIUC was related to a real >> world hardware specification that it was based on. IOW, I think this old >> name was preferrable to calling it "enterprise". >> > > I couldn't agree more. However, IIUC this change was made at the > request of one of the reviewers, although I wasn't part of the > discussion at that point, so I'm not sure who it was. > > Hongbo, could you please share a link to that discussion? > > Thanks, > Ard. >
V1 discussion here: https://www.mail-archive.com/qemu-devel@nongnu.org/msg545775.html >>> - Based on 'virt' machine type. >>> - Re-designed memory map. >>> - EL2 and EL3 are enabled by default. >>> - GIC version 3 by default. >>> - AHCI controller attached to system bus, and then CDROM and hard disc >>> can be added to it. >>> - EHCI controller attached to system bus, with USB mouse and key board >>> installed by default. >>> - E1000E ethernet card on PCIE bus. >>> - VGA display adaptor on PCIE bus. >>> - Default CPU type cortex-a57, 4 cores, and 1G bytes memory. >>> - No virtio functions enabled, since this is to emulate real hardware. >>> - No paravirtualized fw_cfg device either. >>> >>> Arm Trusted Firmware and UEFI porting to this are done accordingly. >>> >>> Signed-off-by: Hongbo Zhang <hongbo.zh...@linaro.org> >>> --- >>> Changes since v1: >>> - rebase on v3.0.0-rc0 >>> - introduce another auxillary patch as 1/2, so this is 2/2 >>> - rename 'sbsa' to 'enterprise' >>> - remove paravirualized fw_cfg >>> - set gic_vertion to 3 instead of 2 >>> - edit commit message to describe purpose of this platform >>> >>> hw/arm/virt-acpi-build.c | 59 +++++++++++++- >>> hw/arm/virt.c | 199 >>> ++++++++++++++++++++++++++++++++++++++++++++++- >>> include/hw/arm/virt.h | 3 + >>> 3 files changed, 255 insertions(+), 6 deletions(-) >> >> Regards, >> Daniel >> -- >> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange >> :| >> |: https://libvirt.org -o- https://fstop138.berrange.com >> :| >> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange >> :|
