Hi Stefan, On 07/25/2018 05:59 AM, Stefan Hajnoczi wrote: > Define a "cortex-m0" ARMv6-M CPU model. > > Most of the register reset values set by other CPU models are not > relevant for the cut-down ARMv6-M architecture. > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > target/arm/cpu.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index 3848ef46aa..7e477c0d23 100644 > --- a/target/arm/cpu.c > +++ b/target/arm/cpu.c > @@ -1255,6 +1255,15 @@ static void arm11mpcore_initfn(Object *obj) > cpu->reset_auxcr = 1; > } > > +static void cortex_m0_initfn(Object *obj) > +{ > + ARMCPU *cpu = ARM_CPU(obj); > + set_feature(&cpu->env, ARM_FEATURE_V6); > + set_feature(&cpu->env, ARM_FEATURE_M);
What about ARM_FEATURE_THUMB2 (T32)? Peter: Since the M0 (optionally?) supports 32x32 multiply, should this cpu use the ARM_FEATURE_THUMB_DSP feature? Else this might trigger an 'Undefined Instruction' in disas_thumb2_insn(). And what about optional ARM_FEATURE_PMSA? Oh this would be cortex_m0plus_initfn() for "cortex-m0-plus", ok. > + > + cpu->midr = 0x410cc200; > +} > + > static void cortex_m3_initfn(Object *obj) > { > ARMCPU *cpu = ARM_CPU(obj); > @@ -1845,6 +1854,8 @@ static const ARMCPUInfo arm_cpus[] = { > { .name = "arm1136", .initfn = arm1136_initfn }, > { .name = "arm1176", .initfn = arm1176_initfn }, > { .name = "arm11mpcore", .initfn = arm11mpcore_initfn }, > + { .name = "cortex-m0", .initfn = cortex_m0_initfn, > + .class_init = arm_v7m_class_init }, What about renaming arm_v7m_class_init -> arm_m_profile_class_init (such your patches 1 and 2)? > { .name = "cortex-m3", .initfn = cortex_m3_initfn, > .class_init = arm_v7m_class_init }, > { .name = "cortex-m4", .initfn = cortex_m4_initfn, > Regards, Phil.