On 2 August 2018 at 20:13, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > Hi Peter, > > On 07/30/2018 10:23 AM, Peter Maydell wrote: >> The tests in tests/vm/ seem to make some attempt to cope with the >> host system not allowing the user to use KVM, but it doesn't quite >> work. The problem is that tests/vm/basevm.py always uses "-cpu host" >> in the QEMU options it uses to run the VM, and that only works if >> KVM is enabled. If the user can't run KVM then we correctly avoid >> passing it "-enable-kvm" but then QEMU doesn't run because "-cpu host" >> isn't supported... >> >> I guess the right fix here is to use "-cpu max" ? > > I think this is the issue I intended to address in this series: > > http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg03411.html > "tests/vm: Improvements when KVM is not available" > -> > "tests/vm: Use 'host' cpu when KVM is available, else default to 'max'"
Just using "max" seems more straightforward, since the point is that it works everywhere. I thought I'd sent my tests/vm series out earlier this week, but I must have managed to only do the dry-run or something -- I'll send them tomorrow. thanks -- PMM
