On 08/06/2018 08:53 AM, Markus Armbruster wrote: > qtest_qmp_discard_response(...) is shorthand for > qobject_unref(qtest_qmp(...), except it's not actually shorter. > Moreover, the presence of these functions encourage sloppy testing. > Remove them from libqtest. Add them as macros to the tests that use > them, with a TODO comment asking for cleanup. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > --- > tests/ahci-test.c | 3 +++ > tests/boot-order-test.c | 5 ++++- > tests/drive_del-test.c | 3 +++ > tests/fdc-test.c | 4 ++++ > tests/ide-test.c | 5 ++++- > tests/libqtest.c | 27 +-------------------------- > tests/libqtest.h | 27 --------------------------- > tests/migration-test.c | 3 +++ > tests/test-filter-mirror.c | 4 ++++ > tests/test-filter-redirector.c | 4 ++++ > tests/virtio-blk-test.c | 4 ++++ > 11 files changed, 34 insertions(+), 55 deletions(-)
Reviewed-by: Thomas Huth <th...@redhat.com>
