On 06/08/2018 16:33, Emanuele Giuseppe Esposito wrote:
> Rename qpci_init_pc in qpci_new_pc, since the function actually
> allocates a new QPCIBusPC and initialize it.
>
> Signed-off-by: Emanuele Giuseppe Esposito <e.emanuelegiuse...@gmail.com>
> ---
> tests/e1000e-test.c | 2 +-
> tests/i440fx-test.c | 2 +-
> tests/ide-test.c | 2 +-
> tests/libqos/ahci.c | 2 +-
> tests/libqos/libqos-pc.c | 2 +-
> tests/libqos/pci-pc.c | 2 +-
> tests/libqos/pci-pc.h | 9 ++++++++-
> tests/q35-test.c | 4 ++--
> tests/rtl8139-test.c | 2 +-
> tests/sdhci-test.c | 2 +-
> tests/tco-test.c | 2 +-
> tests/usb-hcd-ehci-test.c | 2 +-
> tests/vhost-user-test.c | 2 +-
> 13 files changed, 21 insertions(+), 14 deletions(-)
>
...
> diff --git a/tests/libqos/libqos-pc.c b/tests/libqos/libqos-pc.c
> index a9c1aceaa7..72b3eb46f5 100644
> --- a/tests/libqos/libqos-pc.c
> +++ b/tests/libqos/libqos-pc.c
> @@ -6,7 +6,7 @@
> static QOSOps qos_ops = {
> .init_allocator = pc_alloc_init_flags,
> .uninit_allocator = pc_alloc_uninit,
> - .qpci_init = qpci_init_pc,
> + .qpci_init = qpci_pc_new,
> .qpci_free = qpci_free_pc,
> .shutdown = qtest_pc_shutdown,
> };
I think you should also rename the "qpci_init" field to "qpci_new".
And as we have "qpci_free_pc", it should be "qpci_new_pc", and you
should do the same for qpci_init_spapr -> qpci_new_spapr.
Thanks,
Laurent
