On Fri, Aug 03, 2018 at 07:36:07PM +0200, Marc-André Lureau wrote: > Looking at chardev/spice.c code, I realize compilation was broken for > a while with spice-server < 0.12.3. I propose to bump required version > to 0.12.6, released 3y ago, instead of adding more #ifdef.
Since we introduced our platform support policy[1], it is desired that any min version changes consider what versions our target OS have available. eg take a look at this commit message example: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03796.html could you use repology[2] to do the same for spice to validate that this proposed min version is compatible with distros we target. Regards, Daniel [1] https://qemu.weilnetz.de/doc/qemu-doc.html#Supported-build-platforms [2] https://repology.org/metapackage/spice/versions https://repology.org/metapackage/spice-server/versions -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
