Re: [Qemu-devel] [PATCH 19/21] qapi/block-commit: expose new job properties

[John Snow]

On 08/07/2018 10:52 AM, Eric Blake wrote:
> On 08/06/2018 11:33 PM, John Snow wrote:
>> Signed-off-by: John Snow <js...@redhat.com>
>> ---
>>   blockdev.c           | 8 ++++++++
>>   qapi/block-core.json | 3 ++-
>>   2 files changed, 10 insertions(+), 1 deletion(-)
>>
> 
>> +++ b/qapi/block-core.json
>> @@ -1518,7 +1518,8 @@
>>   { 'command': 'block-commit',
>>     'data': { '*job-id': 'str', 'device': 'str', '*base': 'str',
>> '*top': 'str',
>>               '*backing-file': 'str', '*speed': 'int',
>> -            '*filter-node-name': 'str' } }
>> +            '*filter-node-name': 'str',
>> +            '*auto-finalize': 'bool', '*auto-dismiss': 'bool' } }
> 
> Missing documentation, including a 'since 3.1' tag.
> 

OK, will fix for V2 but I won't respin until I get more feedback.

--js