On 08/13/2018 02:17 AM, Markus Armbruster wrote:
Eric Blake <ebl...@redhat.com> writes:
On 08/10/2018 08:28 AM, Eric Blake wrote:
Instead of using a raw assert, print the information in an
easier to understand way:
/i386/ahci/sanity: tests/libqtest.c:119: kill_qemu() detected QEMU death from
signal 11 (Segmentation fault) (core dumped)
Well, it would help if my commit message actually matched...
+ if (wstatus) {
+ if (WIFEXITED(wstatus)) {
+ fprintf(stderr, "%s:%d: kill_qemu() tried to terminate QEMU "
+ "process but encountered exit status %d\n",
+ __FILE__, __LINE__, WEXITSTATUS(wstatus));
+ } else if (WIFSIGNALED(wstatus)) {
+ int sig = WTERMSIG(wstatus);
+ const char *signame = strsignal(sig) ?: "unknown ???";
+ const char *dump = WCOREDUMP(wstatus) ? " (dumped core)" : "";
+
+ fprintf(stderr, "%s:%d: kill_qemu() detected QEMU death "
+ "from signal %d (%s)%s\n",
...the code.
I got libqtest patches in my queue, and I could stick this patch in.
Would you like me to touch up the commit message when I apply? Or
should I expect v5?
If you don't mind doing the touchup (s/core dumped/dumped core/), then I
don't need to submit v5.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
