On Wed, Aug 15, 2018 at 06:22:51AM +0200, Markus Armbruster wrote: >> My initial patch didn't have the offset. It was suggested by Eric >> Blake in <0a960aa8-2a3f-8667-3d46-cecf8e65e...@redhat.com>: >> >> On Tue, Apr 10, 2018 at 04:33:03PM -0500, Eric Blake wrote: >>> Do you additionally need an offset where to start reading from within >>> the file (that is, since you already have the 'size' parameter to avoid >>> reading the entire file, and the 'val' parameter to target anywhere in >>> physical memory, how do I start reading anywhere from the file)? >> >> It sounded useful to me so I added it. > > Feels like an optional parameter to me.
For the HMP or the QMP interface? If you think 'offset' is not necessary I can also drop it completely. Regards Simon -- + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9
signature.asc
Description: PGP signature
