On Wed, Aug 15, 2018 at 04:25:16PM -0500, Eric Blake wrote: > On 08/15/2018 10:59 AM, Jeff Cody wrote: > >The function job_cancel_async() will always cause an assert for blockjob > >user resume. We set job->user_paused to false, and then call > >job->driver->user_resume(). In the case of blockjobs, this is the > >block_job_user_resume() function. > > > >In that function, we assert that job.user_paused is set to true. > >Unfortunately, right before calling this function, it has explicitly > >been set to false. > > > >The fix is pretty simple: set job->user_paused to false only after the > >job user_resume() function has been called. > > > >Signed-off-by: Jeff Cody <jc...@redhat.com> > >--- > > job.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Does this need to CC qemu-stable? >
Good point, yes. I'm going to do a v2 with an iotest, and I'll CC qemu-stable on that one. > Reviewed-by: Eric Blake <ebl...@redhat.com> > Thanks -Jeff
