Thomas Huth <th...@redhat.com> wrote: > Certain device introspection crashes used to only happen if you were > using a certain machine, e.g. if the machine was using serial_hd() or > nd_table[], and a device was trying to use these in its instance_init > function, too. > > To be able to catch these problems, let's extend the device-introspect > test to check the devices on all machine types, with and without the > "-nodefaults" parameter (since this makes a difference sometimes, too). > Since this is a rather slow operation, and most of the problems are > already handled by testing with the "none" machine only, the test with > all machines is only run in the "make check SPEED=slow" mode. > > Reviewed-by: Markus Armbruster <arm...@redhat.com> > Signed-off-by: Thomas Huth <th...@redhat.com>
Reviewed-by: Juan Quintela <quint...@redhat.com> > --- > tests/device-introspect-test.c | 32 +++++++++++++++++++++++++++++--- > 1 file changed, 29 insertions(+), 3 deletions(-) > > diff --git a/tests/device-introspect-test.c b/tests/device-introspect-test.c > index a38193b..a25092d 100644 > --- a/tests/device-introspect-test.c > +++ b/tests/device-introspect-test.c > @@ -221,13 +221,13 @@ static void test_device_intro_abstract(void) > qtest_end(); > } > > -static void test_device_intro_concrete(void) > +static void test_device_intro_concrete(const void *args) ^^^^^^^^^^^^^^^^ I hate this game of casts, but I have no good suggestions, sorry.