On 23 August 2018 at 18:21, Richard Henderson
<richard.hender...@linaro.org> wrote:
> On 08/20/2018 07:11 AM, Peter Maydell wrote:
>> The IoTKit does not have any Master Security Contollers itself,
>> but it does provide registers in the secure privilege control
>> block which allow control of MSCs in the external system.
>> Add support for these registers.
>>
>> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
>> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
>> ---
>> include/hw/misc/iotkit-secctl.h | 14 +++++++
>> hw/misc/iotkit-secctl.c | 73 +++++++++++++++++++++++++++++----
>> 2 files changed, 79 insertions(+), 8 deletions(-)
>
>
> Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
>
>>
>> +static bool needed_always(void *opaque)
>> +{
>> + return true;
>> +}
>
> We really should either make NULL imply just this,
> or export one copy from generic code. Soon...
I sent a patch for doing the former, but it got some pushback
from Juan:
https://patchwork.ozlabs.org/patch/954507/
thanks
-- PMM
