On Wed, Sep 12, 2018 at 08:42:15AM -0400, Jeff Cody wrote: > On Wed, Sep 12, 2018 at 12:38:56PM +0200, Kevin Wolf wrote: > > Am 11.09.2018 um 20:37 hat Jeff Cody geschrieben: > > > On Tue, Sep 11, 2018 at 02:22:31PM -0400, John Snow wrote: > > > > Once we load the image, will the header get rewritten into a compliant > > > > format? > > > > > > Hmm - I think in some code paths, but not all. I don't think the answer > > > is > > > 'yes' universally, alas. > > > > Can't we explicitly call BdrvChildRole.update_filename() for all parents > > when we open a legacy filename? We'd just need to add the callback to > > child_file, which would propagate it to the parents of the format layer, > > and then just opening the image with a legacy backing file link once > > would fix the problem for this image. > > > > Yes, that is a good idea. I will spin a v5 with that added.
On second thought; how about we address updating the legacy filename header in a separate patch series? -Jeff
