On Thu, Sep 20, 2018 at 02:27:02PM +0200, Markus Armbruster wrote: > Kashyap Chamarthy <kcham...@redhat.com> writes: [...] > > --- > > qapi/misc.json | 6 +++++- > > qemu-deprecated.texi | 5 +++++ > > 2 files changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/qapi/misc.json b/qapi/misc.json > > index d450cfef21..83bc9ad0ee 100644 > > --- a/qapi/misc.json > > +++ b/qapi/misc.json > > @@ -1104,7 +1104,11 @@ > > ## > > # @cpu-add: > > # > > -# Adds CPU with specified ID > > +# Adds CPU with specified ID. > > +# > > +# Notes: This command is deprecated. The `device_add` command should be > > +# used instead. See the `query-hotpluggable-cpus` command for > > +# details. > > # > > # @id: ID of CPU to be created, valid values [0..max_cpus) > > # > > Eduardo pointed out that query-hotpluggable-cpus's documentation is > lacking. Add a suitable TODO there?
Yes, please. > > > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > > index 1b9c007f12..9c6d70d43a 100644 > > --- a/qemu-deprecated.texi > > +++ b/qemu-deprecated.texi > > @@ -155,6 +155,11 @@ The ``query-cpus'' command is replaced by the > > ``query-cpus-fast'' command. > > The ``arch'' output member of the ``query-cpus-fast'' command is > > replaced by the ``target'' output member. > > > > +@subsection cpu-add (since 3.1) > > + > > +The intended functionality of ``cpu-add'' command, which is the ability > > +to hot-plug vCPUs, can now be achieved by the ``device_add'' command. > > + > > For me, "now" suggests device_add can achieve this since 3.1. Scratch > "now"? Agreed. I would also try to write a shorter and simpler sentence, and mention query-hotpluggable-cpus. e.g.: The ``device_add'' command should be used for hotplugging VCPUs instead of ``cpu-add''. See the documentation of the ``query-hotpluggable-cpus'' command for additional details. > > > @section System emulator devices > > > > @subsection ivshmem (since 2.6.0) -- Eduardo
