On 2018-09-25 10:26, Peter Maydell wrote: > On 13 September 2018 at 13:53, Juan Quintela <quint...@redhat.com> wrote: >> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: >> >> Merge remote-tracking branch >> 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 >> 16:44:20 +0100) >> >> are available in the Git repository at: >> >> git://github.com/juanquintela/qemu.git tags/migration/20180913 >> >> for you to fetch changes up to 418fe4f69648b4f3f0afd2588926deafac81cfe8: >> >> tests/migration: Enable the migration test on s390x, too (2018-09-13 >> 14:06:26 +0200) >> >> ---------------------------------------------------------------- >> migration/next for 20180913 >> >> Hi this patchset has all pending migration queue that I have (It >> superceedes the previous one). >> >> - fix rdma_return_path (david) >> >> - s390 migration-test (thomas) >> I ported it to the nema Makefile architecuter >> Please thomas, confirm that you agree with my changes >> >> - aarch64 migration-test (wei) >> - lots of compression fixes (xiao) >> >> Please, apply. > > Hi. This causes the s390 migration test to fail on sparc host: > > TEST: tests/migration-test... (pid=83922) > /s390x/migration/deprecated: OK > /s390x/migration/bad_dest: OK > /s390x/migration/postcopy/unix: > qemu-system-s390x: load of migration failed: Input/output error > Broken pipe > /home/pm215/qemu/tests/libqtest.c:121: kill_qemu() tried to terminate > QEMU process but encountered exit status 1 > FAIL > GTester: last random seed: R02S7b77f29679b5d4224f073b2cbaed1bff > (pid=83946) > /s390x/migration/postcopy/recovery: > Broken pipe > /home/pm215/qemu/tests/libqtest.c:121: kill_qemu() tried to terminate > QEMU process but encountered exit status 1 > FAIL > GTester: last random seed: R02Sefc9588e457bc609665979e83b5071bd > (pid=83958) > /s390x/migration/precopy/unix: > qemu-system-s390x: Unexpected storage key flag data: 0 > qemu-system-s390x: error while loading state for instance 0x0 of > device 's390-skeys' > qemu-system-s390x: load of migration failed: Invalid argument > Broken pipe > /home/pm215/qemu/tests/libqtest.c:121: kill_qemu() tried to terminate > QEMU process but encountered exit status 1 > FAIL > GTester: last random seed: R02S23be4e2c4ae37551a17c8ae0a9675b47 > (pid=83969) > FAIL: tests/migration-test > > > This is almost certainly because of these new misaligned accesess, > which cause segfaults on sparc, but show up as runtime errors > with the clang sanitizer on x86: > > TEST: tests/migration-test... (pid=7176) > /s390x/migration/deprecated: OK > /s390x/migration/bad_dest: OK > /s390x/migration/postcopy/unix: > /home/petmay01/linaro/qemu-for-merges/include/migration/qemu-file-types.h:63:22: > runti > me error: load of misaligned address 0x55e9f9b58f67 for type 'const > uint16_t' (aka 'const unsigned short'), which requires 2 byte > alignment > 0x55e9f9b58f67: note: pointer points here > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 00 00 00 00 00 00 00 00 00 00 > ^
Ok, I'll have a look. (I think this PULL request should not go in anyway since patch 12 is missing the "strip" of the binary, so that the header is unnecessary big ...) Thomas