On Mon, Oct 01, 2018 at 11:28:17AM +0200, Thomas Huth wrote:
> On 2018-09-25 18:02, Kashyap Chamarthy wrote:
[...]
> > +++ b/qapi/misc.json
> > @@ -1104,7 +1104,11 @@
> > ##
> > # @cpu-add:
> > #
> > -# Adds CPU with specified ID
> > +# Adds CPU with specified ID.
> > +#
> > +# Notes: This command is deprecated. The `device_add` command should be
>
> s/Notes/Note/ ?
Yeah, first I wrote the singular. But went with plural as I saw it as
it was the 'majority' pattern:
$> git grep "Note:" qapi/misc.json | wc -l
13
$> git grep "Notes:" qapi/misc.json | wc -l
18
Maybe people use the plural, "Notes", as they can add multiple entries.
[...]
> Do you plan to keep the "cpu-add" HMP command? hmp_cpu_add() currently
> is only a wrapper for qmp_cpu_add(), so if you plan to get rid of the
> QMP command, it might make sense to deprecate the HMP command in the
> same breath, too.
Yeah, I did think about deprecating the HMP variant; and even brought it
up with Dave Gilbert the other day. He pointed out an example commit of
yours (559964a1) on how to mark an HMP command as deprecated. :-)
Thanks for the reminder. Will add it as a TODO for the next revision.
--
/kashyap
