Marc-André Lureau <marcandre.lur...@gmail.com> writes: > Hi > > On Mon, Oct 8, 2018 at 9:51 PM Markus Armbruster <arm...@redhat.com> wrote: >> >> Calling error_report() in a function that takes an Error ** argument >> is suspicious. chardev_init_func() does that, and then fails without >> setting an error. Its caller main(), via qemu_opts_foreach(), is fine >> with it, but clean it up anyway. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > commit title is wrong, apart from that:
Fixing... > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> Thanks!