On 19 October 2018 at 14:14, Thomas Huth <th...@redhat.com> wrote: > The "unimplemented-device" is currently only used for one arm board.
? It's used in all the MPS boards, several of the imx SoCs, the nrf51 SoC used by the microbit, and by the stellaris boards. > Let's add a CONFIG switch to make sure that we only compile it when > it is really necessary. > > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > default-configs/arm-softmmu.mak | 1 + > hw/misc/Makefile.objs | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak > index 6f2ffc1..dc9730f 100644 > --- a/default-configs/arm-softmmu.mak > +++ b/default-configs/arm-softmmu.mak > @@ -7,6 +7,7 @@ CONFIG_NAND=y > CONFIG_OR_IRQ=y > CONFIG_SPLIT_IRQ=y > CONFIG_REGISTER=y > +CONFIG_UNIMP=y > CONFIG_ECC=y > CONFIG_SERIAL=y > CONFIG_SERIAL_ISA=y This seems awkward to me. The 'unimplemented' device is supposed to be an entirely generic thing usable in any board model. If we only turn it on in the arm-softmmu.mak then it means faffing around with the default-configs/ whenever it gets used in a different architecture. In particular, there's a pull request on the list that uses it in a sparc board, so this patch will break compile on sparc once that pullreq lands. thanks -- PMM
