On Tue, Oct 30, 2018 at 05:03:28PM +0100, Paolo Bonzini wrote: > On 30/10/2018 15:13, Samuel Ortiz wrote: > >> Just a quick question before I go and actually apply the patches to look > >> at the resulting code: is there any reason why you didn't add the > >> MachineState and/or AcpiBuilder to AcpiBuildState, similar to how it was > >> in v1? > > > > With v1 I was not adding MachineState to AcpiBuildState, I may be > > missing your point. > > Do you mean adding an AcpiBuilder pointer to AcpiConfiguration? > > No, what I was remembering is the FirmwareBuildState, which you have > removed according to my review. Sorry, KVM Forum was a bit exhausting. :) No worries, it was exhausting indeed :)
Cheers, Samuel.
