On Tue, Oct 30, 2018 at 12:35:15PM +0000, Aleksandar Markovic wrote: > Perhaps checkpatch.pl should make sure the commit messages do not contain > "address@hidden" and "Reviewed-off-by"? > > $ git log | grep address@hidden > Signed-off-by: Michael S. Tsirkin <address@hidden> > Signed-off-by: Ronald Hecht <address@hidden> > Signed-off-by: Justin Chevrier <address@hidden> > Signed-off-by: Justin Chevrier <address@hidden> > Signed-off-by: Justin Chevrier <address@hidden>
This makes sense... > > $ git log | grep Reviewed-off-by > Reviewed-off-by: Pavel Dovgalyuk <pavel.dovga...@ispras.ru> > Reviewed-off-by: Anthony Liguori <aligu...@us.ibm.com> but I'm not convinced it is worth doing this, because the set of mistakes people have made is enourmous, so it turns into a game of whack-a-mole. git log | grep -- '-by:' | sed -e 's/-by:.*/-by/' | sed -e 's/ //g' | sort | uniq -c 3127 Acked-by 1 ACKed-by 1 Acked-off-by 5 Analyzed-by 3 Approximately-suggested-by 3 Co-authored-by 1 Edited-by 2 eviewed-by 1 Fine-with-me'd-by 1 Fix-suggested-by 3 Found-by 1 Inspired-by 1 Introduced-by 1 Original-patch-by 1 Problem-spotted-by 2 Proposed-by 2 Rebased-by 1 Release-acked-by 1 Reported-and-analyzed-by 2 Reported-and-tested-by 1 Reported-and-Tested-by 1834 Reported-by 1 Reportyed-by 7 Requested-by 2 Reveiwed-by 1 Revieed-by 2 Revieved-by 4 Reviewd-by 30991 Reviewed-by 2 Reviewed-off-by 3 Reviwed-by 1 Rported-by 1 Sgined-off-by 1 Sigend-off-by 1 Signed-by 1 Signed-of-by 97837 Signed-off-by 1 Signer-off-by 4 Singed-off-by 1 Spotted-by 660 Suggested-by 1951 Tested-by 1 Tested-off-by 1 xSigned-off-by Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|