Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 20181105140327.8363-1-v.mayats...@gmail.com Subject: [Qemu-devel] [PATCH 0/1 resend] Add vhost-pci-blk driver === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 19803cc4ae Add vhost-pci-blk driver === OUTPUT BEGIN === Checking PATCH 1/1: Add vhost-pci-blk driver... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #82: new file mode 100644 ERROR: Error messages should not contain newlines #229: FILE: hw/block/vhost-blk.c:143: + error_report("Error opening backing store: %d\n", -errno); ERROR: braces {} are necessary for all arms of this statement #241: FILE: hw/block/vhost-blk.c:155: + if (s->bs_fd > 0) [...] ERROR: space prohibited after that '-' (ctx:WxW) #327: FILE: hw/block/vhost-blk.c:241: + int fd = - 1; ^ WARNING: line over 80 characters #331: FILE: hw/block/vhost-blk.c:245: + error_report("Can't open device %s: %d\n", blk_bs(s->blk)->filename, errno); ERROR: code indent should never use tabs #331: FILE: hw/block/vhost-blk.c:245: +^I error_report("Can't open device %s: %d\n", blk_bs(s->blk)->filename, errno);$ ERROR: Error messages should not contain newlines #331: FILE: hw/block/vhost-blk.c:245: + error_report("Can't open device %s: %d\n", blk_bs(s->blk)->filename, errno); ERROR: code indent should never use tabs #332: FILE: hw/block/vhost-blk.c:246: +^I goto out;$ ERROR: code indent should never use tabs #336: FILE: hw/block/vhost-blk.c:250: +^I ret = ioctl(fd, BLKGETSIZE, &var);$ ERROR: code indent should never use tabs #337: FILE: hw/block/vhost-blk.c:251: +^I var64 = var;$ ERROR: code indent should never use tabs #340: FILE: hw/block/vhost-blk.c:254: +^I error_report("Can't get drive size: %d\n", errno);$ ERROR: Error messages should not contain newlines #340: FILE: hw/block/vhost-blk.c:254: + error_report("Can't get drive size: %d\n", errno); ERROR: code indent should never use tabs #341: FILE: hw/block/vhost-blk.c:255: +^I goto out;$ ERROR: line over 90 characters #347: FILE: hw/block/vhost-blk.c:261: + error_report("Can't get drive logical sector size, assuming 512: %d\n", errno); ERROR: code indent should never use tabs #347: FILE: hw/block/vhost-blk.c:261: +^I error_report("Can't get drive logical sector size, assuming 512: %d\n", errno);$ ERROR: Error messages should not contain newlines #347: FILE: hw/block/vhost-blk.c:261: + error_report("Can't get drive logical sector size, assuming 512: %d\n", errno); ERROR: code indent should never use tabs #348: FILE: hw/block/vhost-blk.c:262: +^I var = 512;$ ERROR: braces {} are necessary for all arms of this statement #360: FILE: hw/block/vhost-blk.c:274: + if (fd > 0) [...] ERROR: code indent should never use tabs #361: FILE: hw/block/vhost-blk.c:275: +^I close(fd);$ ERROR: code indent should never use tabs #410: FILE: hw/block/vhost-blk.c:324: +^Igoto virtio_err;$ ERROR: line over 90 characters #413: FILE: hw/block/vhost-blk.c:327: + ret = vhost_dev_init(&s->dev, (void *)(uintptr_t)s->vhostfd, VHOST_BACKEND_TYPE_KERNEL, 0); total: 19 errors, 2 warnings, 613 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com