On 02/11/2018 10:56, Philippe Mathieu-Daudé wrote:
>>>
>>> }
>>> /* RSDP */
>>> -static GArray *
>>> +static void
>>> build_rsdp(GArray *rsdp_table, BIOSLinker *linker, unsigned
>>> xsdt_tbl_offset)
>>> {
>>> AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof
>>> *rsdp);
>>
>> Why change this? It's not related to your patch purpose.
>
> This patch updates include/hw/acpi/aml-build.h to export the
> build_rsdp() function.
> Since this file includes this header, the orototype needs to match.
But then it should also remove the "return". I think something is
broken for bisectability between this patch and patch 4.
Perhaps this patch should already rename the function to
build_rsdp_rsdt, and patch 4 should move build_rsdp from hw/arm to hw/acpi?
Paolo
