On 11/06/2018 02:46 PM, Paolo Bonzini wrote: > On 06/11/2018 19:43, Peter Maydell wrote: >> hw/ide/ahci.c > > Even though AHCIState is not a QOM object, all of its users are > (TYPE_SYSBUS_AHCI is in this file, TYPE_ICH9_AHCI is in hw/ide/ich.c). > Yeah, if there's something *further* that needs to happen, let me know. I'm not sure what the QOM ideal is. Is there a reference implementation for what we consider to be a proper QOM device that I can measure against? A list of forbidden ABIs I ought not use? (S/ATA device realization is in itself already particularly bizarre where we have a skeleton list of properties in QOM and then we just malloc the bulk of the structure we actually use, but I think it's not worth fixing to be nicer because I haven't figured out a way to do it without breaking backwards compatibility, so I've just left it alone.) --js
- [Qemu-devel] List of files containing devices whic... Peter Maydell
- Re: [Qemu-devel] List of files containing dev... Philippe Mathieu-Daudé
- Re: [Qemu-devel] List of files containing... Peter Maydell
- Re: [Qemu-devel] List of files contai... Philippe Mathieu-Daudé
- Re: [Qemu-devel] List of files containing dev... Paolo Bonzini
- Re: [Qemu-devel] List of files containing dev... Paolo Bonzini
- Re: [Qemu-devel] List of files containing... Alistair Francis
- Re: [Qemu-devel] List of files containing... John Snow
- Re: [Qemu-devel] List of files contai... Paolo Bonzini
- Re: [Qemu-devel] List of files containing... Peter Maydell
- Re: [Qemu-devel] List of files contai... Paolo Bonzini
- Re: [Qemu-devel] List of files containing dev... Palmer Dabbelt
- Re: [Qemu-devel] List of files containing dev... Mark Cave-Ayland
- Re: [Qemu-devel] List of files containing... Peter Maydell
- Re: [Qemu-devel] List of files contai... Mark Cave-Ayland
- Re: [Qemu-devel] List of files co... Peter Maydell
- Re: [Qemu-devel] List of files containing dev... Gerd Hoffmann
- Re: [Qemu-devel] List of files containing... Gerd Hoffmann