On Fri, Oct 19, 2018 at 5:40 PM Daniel P. Berrangé <berra...@redhat.com> wrote:
>
> IN_ISDIR is not a bit that one can request when registering a
> watch with inotify_add_watch. Rather it is a bit that is set
> automatically when reading events from the kernel.
>
> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> hw/usb/dev-mtp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
> index 00a3691bae..f026419e47 100644
> --- a/hw/usb/dev-mtp.c
> +++ b/hw/usb/dev-mtp.c
> @@ -642,8 +642,7 @@ static void usb_mtp_inotify_cleanup(MTPState *s)
>
> static int usb_mtp_add_watch(int inotifyfd, char *path)
> {
> - uint32_t mask = IN_CREATE | IN_DELETE | IN_MODIFY |
> - IN_ISDIR;
> + uint32_t mask = IN_CREATE | IN_DELETE | IN_MODIFY;
>
> return inotify_add_watch(inotifyfd, path, mask);
> }
> --
> 2.17.2
>
>
--
Marc-André Lureau
