On 07.11.18 13:59, Alberto Garcia wrote: > This function is used to put the hidden and secondary disks in > read-write mode before launching the backup job, and back in read-only > mode afterwards. > > This patch does the following changes: > > - Use an options QDict with the "read-only" option instead of > passing the changes as flags only. > > - Simplify the code (it was unnecessarily complicated and verbose). > > - Fix a bug due to which the secondary disk was not being put back > in read-only mode when writable=false (because in this case > orig_secondary_flags always had the BDRV_O_RDWR flag set). > > - Stop clearing the BDRV_O_INACTIVE flag. > > The flags parameter to bdrv_reopen_queue() becomes redundant and we'll > be able to get rid of it in a subsequent patch. > > Signed-off-by: Alberto Garcia <be...@igalia.com> > --- > block/replication.c | 45 +++++++++++++++++++++------------------------ > 1 file changed, 21 insertions(+), 24 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
