On Sun, Nov 11, 2018 at 3:53 PM Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > Hi Max, > > On Thu, Nov 1, 2018 at 12:02 AM Richard Henderson > <richard.hender...@linaro.org> wrote: > > > > On 10/31/18 9:35 PM, Max Filippov wrote: > > > gdb_regmap::num_core_regs field is initialized incorrectly in the dc232b > > > and dc233c configurations. As a result the following message is > > > displayed when attaching to an xtensa linux-user process: > > > > > > "Register 105 is not available", > > > > > > and gdb is unable to control the inferior. > > > > > > Now that xtensa_count_regs does the right thing, remove manual > > > initialization of these fields from the affected configurations and let > > > xtensa_finalize_config initialize them. > > > > > > Cc: qemu-sta...@nongnu.org > > > Signed-off-by: Max Filippov <jcmvb...@gmail.com> > > > --- > > > target/xtensa/core-dc232b.c | 2 -- > > > target/xtensa/core-dc233c.c | 2 -- > > > 2 files changed, 4 deletions(-) > > > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > > Can we include this patch for the 3.2 release?
I've found that this version is wrong (register lists are not terminated for these two cores), so I sent v2. After that I've found that it's still wrong, i.e. the register 105 is still not available with v2. I dug a bit deeper and it looks like register handling should probably be the same for both system and linux-user cases. I'll post v3 after some more testing in a few days. -- Thanks. -- Max
