Peter Maydell <peter.mayd...@linaro.org> writes: > On 9 November 2018 at 14:14, Gerd Hoffmann <kra...@redhat.com> wrote: >> Broken (segfaultson first keypress) and appearently unused. >> >> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
Please show the reproducer in the commit message. Stack backtrace wouldn't hurt. >> --- >> include/hw/bt.h | 3 - >> hw/bt/hid.c | 554 >> ---------------------------------------------------- >> vl.c | 34 +--- >> hw/bt/Makefile.objs | 3 +- >> qemu-options.hx | 9 - >> 5 files changed, 2 insertions(+), 601 deletions(-) >> delete mode 100644 hw/bt/hid.c > > Are we definitely happy that all the use cases for > this code segfault, not just the one you tested ? Are there any others? > Does it cost us much to mark this deprecated in 3.1 > and drop it in 4.0 ? The cost is offering a known-to-be-broken option to users. The other half of the tradeoff: what would it gain us?
