On Tue, 13 Nov 2018 11:17:19 +0000 xiezhide <xiezh...@huawei.com> wrote:
> Following is the the patch header, user name and mail are the same at From > and Signed-off-by : > From and Signed-off-by are the same indeed but x00390961 doesn't look like a valid name. You should read the following page. It explains everything you need to know in order to send useful contributions. https://wiki.qemu.org/Contribute/SubmitAPatch About Signed-off-by: https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line "Please use your real name to sign a patch (not an alias or acronym)." Cheers, -- Greg > ------------------- > From 457f3168eca2d041bbfcad822ad9004e29a3840c Mon Sep 17 00:00:00 2001 > From: x00390961 <xiezh...@huawei.com> > Date: Wed, 14 Nov 2018 01:03:49 +0800 > Subject: [PATCH 1/3] fsdev-throttle-qmp: refactor code for qmp interface for > io throttling > > This patch includes two parts: > 1. factor out throttle code to reuse code > 2. use ThrottleLimits structure > > Signed-off-by: x00390961 <xiezh...@huawei.com> > > > Anyway, let me try git send-email > > Thanks > Kidd > > -----Original Message----- > From: Greg Kurz [mailto:gr...@kaod.org] > Sent: 2018年11月13日 18:29 > To: xiezhide <xiezh...@huawei.com> > Cc: qemu-devel@nongnu.org; Eric Blake <ebl...@redhat.com>; arm...@redhat.com; > dgilb...@redhat.com; be...@igalia.com; aneesh.ku...@linux.vnet.ibm.com > Subject: Re: [Qemu-devel][PATCH v1 0/3] fsdev-throttle-qmp: refactor code for > qmp interface > > Hi Kidd, > > This posting is still broken: no threading and missing leading blanks on > unchanged lines. Also is x00390961 really your name of choice ? > > In some other mail, you mentioned copy-paste to an outlook mail client... > please don't do that to post series. Use git format-patch and git send-email > instead and you'll get the formatting and threading right. > > Cheers, > > -- > Greg > > On Tue, 13 Nov 2018 09:59:54 +0000 > xiezhide <xiezh...@huawei.com> wrote: > > > This patches provide qmp interface to query/set io throttle parameters of a > > fsdev. > > Some of patches also refactor the code and structure that was present in > > block and fsdev files. > > > > x00390961 (3): > > fsdev-throttle-qmp: refactor code for qmp interface for io throttling > > fsdev-throttle-qmp: qmp interface for fsdev io throttling > > fsdev-throttle-qmp: hmp interface for fsdev io throttling > > > > Makefile | 20 +++- > > Makefile.objs | 8 ++ > > block/throttle.c | 6 +- > > blockdev.c | 96 +---------------- > > fsdev/qemu-fsdev-dummy.c | 11 ++ > > fsdev/qemu-fsdev-throttle.c | 144 +++++++++++++++++--------- > > fsdev/qemu-fsdev-throttle.h | 6 +- > > fsdev/qemu-fsdev.c | 29 ++++++ > > hmp-commands-info.hx | 15 +++ > > hmp-commands.hx | 15 +++ > > hmp.c | 83 +++++++++++++-- > > hmp.h | 4 + > > include/qemu/throttle-options.h | 3 +- > > include/qemu/throttle.h | 4 +- > > include/qemu/typedefs.h | 1 + > > monitor.c | 41 ++++---- > > qapi/block-core.json | 122 +--------------------- > > qapi/fsdev.json | 96 +++++++++++++++++ > > qapi/qapi-schema.json | 1 + > > qapi/tlimits.json | 89 ++++++++++++++++ > > qmp.c | 12 +++ > > util/throttle.c | 224 > > ++++++++++++++++++++++++++-------------- > > 22 files changed, 654 insertions(+), 376 deletions(-) create mode > > 100644 qapi/fsdev.json create mode 100644 qapi/tlimits.json > > > > v0 -> v1: > > Addressed comments from Eric Blake and Greg Kurz. > > Fix patch corrupt issue due to email client change the patch format > > with copy-to-paster Break patch to patches > > > > -- > > 1.8.3.1 > > >