On 11/15/18 4:22 PM, Philippe Mathieu-Daudé wrote:
On 15/11/18 20:24, miny...@acm.org wrote:
From: Corey Minyard <cminy...@mvista.com>
smbus.c and smbus.h had device side code, master side code, and
smbus.h has some smbus_eeprom.c definitions. Split them into
separate files.
Lovely cleanup!
Yes, this really needed to be done. It took me a while to understand
this code originally because it was all mixed up.
I've fixed the things you pointed out. One thing, though:
diff --git a/include/hw/i2c/smbus_eeprom.h
b/include/hw/i2c/smbus_eeprom.h
new file mode 100644
index 0000000000..2f56e5dc4e
--- /dev/null
+++ b/include/hw/i2c/smbus_eeprom.h
@@ -0,0 +1,11 @@
You missed the copyright notice here.
Other files don't have copyright notices (i2c.h, for instance), and for
the smbus.[ch] case the copyrights are kind of mixed up, the include
files had the big header with a copyright by one company and the C
file had a different copyright notice by a different company.
Not a huge deal, but I didn't include it in that file because I didn't
think it was necessary. I'm wondering if it would be best to
establish a style like Linux has, with the // SPDX... thing on the
first line.
Thanks,
-corey
