"Michael S. Tsirkin" <m...@redhat.com> writes: > On Wed, Nov 21, 2018 at 11:57:18AM +0000, Daniel P. Berrangé wrote: >> On Wed, Nov 21, 2018 at 03:28:29PM +0400, Marc-André Lureau wrote: >> > Hi >> > >> > On Wed, Nov 21, 2018 at 3:22 PM Li Qiang <liq...@gmail.com> wrote: >> > > >> > > The fcntl will change the flags directly, use qemu_set_nonblock() >> > > instead. >> > >> > qemu_set_nonblock() will preserve the existing flags. And on windows, >> > it will register the FD to the event loop. >> > that's a reasonable thing to do, is this fixing an actual bug? >> >> tap.c is only built with CONFIG_POSIX. Win32 is completely separate >> in tap-win32.c. So the event loop reg doesn't apply. >> >> I agree it is good to preserve fcntl flags though, so this patch >> looks desirable. >> >> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > > Sure > > Acked-by: Michael S. Tsirkin <m...@redhat.com> > > but really not for this release I guess as we are in freeze.
That's fair. > So thanks! And pls remember to ping after the release. I strongly recommend maintainers do not use patch submitters as substitutes for git branches. Just create a branch for collecting stuff for the next development cycle, merge the thing, say thank you, and let the patch submitter move on.
