On Tue, 27 Nov 2018 at 12:17, Stefan Weil <s...@weilnetz.de> wrote: > > These two patches fix wrong format strings used in disas/nanomips. > > The first patch replaces proprietary data types by POSIX data types, > because otherwise the PRI... macros cannot be used in the second patch.
I think this is a good idea, but that first patch is a huge patch for this point in the 3.1 release cycle. Can we fix the warnings by just casting the arguments to the img::format() function ? > Those patches are only relevant for 3.1 if full nanomips support is considered > important enought and if QEMU is used on big endian machines (I think > the old code will work on little endian hosts even with wrong format > strings). It only affects the disassembler, which is a debug tool. A week ago this would have been a fairly definite "yes, fix it" issue; at this point, with rc3 due to go out today, it's a bit trickier to justify. (rc3 will be the last rc unless any showstopper issues turn up.) > I use those patches for QEMU for Windows because that is compiled with > more compiler warnings, so compilation would fail without the fix. My Windows cross-compiler builds work OK, FWIW, and -Werror is only enabled by default for Linux builds, so warnings shouldn't result in build failures. thanks -- PMM
