On Wed, Nov 28, 2018 at 10:58:14AM +0100, Thomas Huth wrote: > Clang 3.4 does not know the "flatten" attribute yet. We've already > introduced the QEMU_FLATTEN macro for this in commit 97ff87c0ed020c2, > so use this macro now here, too, to fix this issue. > > Signed-off-by: Thomas Huth <th...@redhat.com>
Although we currently only aim to support CLang and GCC, we don't have any checks for a minimum version of these two tools in configure. So I was wondering if we actually still need to support CLang 3.4 at all in QEMU, given our targetted build platforms. Unfortunately repology.org is failing me in reporting clang versions for most distros, so I don't have an answer yet. I do see that Debian Jessie however ships clang == 3.5 and that's usually the oldest distro if RHEL hasn't got something older. If we did explicitly check min gcc + clang versions, we could sanitize stuff such as hacks for ancient clang 3.2 which lacks int128 support. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
