Markus Armbruster <arm...@redhat.com> 于2018年11月27日周二 下午8:38写道：
> Darren Kenny <darren.ke...@oracle.com> writes: > > > Hi Li Qiang, > > > > This is only a suggestion, I'm sure someone else might also correct > > me, but I'm not sure the subject above really describes what is > > happening in the commit as a whole. > > > > It seems to miss the point that the main change here is to use a > > link type property, so maybe it might be better written as something > > along the lines of: > > > > Subject: [PATCH v2 2/2] hw: vmmouse: use link property instead of > pointer > > Drop DEFINE_PROP_PTR() and replace with a link pointer via an > > instance init function (vmmouse_instance_initfn). > > Yes, that's better. Or take inspiration from recent similar work, such > as commit a8299ec1b24, and say something like > > vmmouse: Use link instead of pointer property > > According to qdev-properties.h, properties of pointer type should > be avoided. Turn "ps2_mouse" into a link. > > Preferably with the commit message improved along these lines: > Reviewed-by: Markus Armbruster <arm...@redhat.com> > Hi Darren and Markus, Thanks so much for your advice. A new revision has been sent out. Thanks, Li Qiang > > [...] >
