03.12.2018 16:59, Max Reitz wrote: > On 29.11.18 11:17, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> v2: add fix:) >> >> We've faced the following mirror bug: >> >> Just run mirror on qcow2 image more than 1G, and qemu is in dead lock. > > So because apparently there is going to be an rc4 anyway (like basically > always...), I'd really like to bring this fix into it, unless there are > any objections from anyone (though all of you are more than welcome to > explicitly agree, too :-)). > > Do you have any plans for the iotest? Right now, I'd rather just take > patch 1 as-is and add the test later, but then again, adding a patch for > rc4 without a test is not so nice either, I suppose. > > Max >
I think, everything is better with test:) I can't say that I really like your additions, because it's anyway a kind of cheating, less real-life, but on the other hand, as I understand, allocating a lot of disk space in iotests is a bad thing too. May be it should be a kind of parameter, with default to your variant, something like ./check --big-disk-allocations-allowed :). But let's commit at least the test with your additions. -- Best regards, Vladimir
